Should we use preempt_disable() in sleep_on_common()?
From: liu pf
Date: Thu Dec 03 2009 - 01:49:22 EST
Hi:
I am puzzled with the following scenario. Could anyone enlighten me?
Thanks
pfliu
static long __sched
sleep_on_common(wait_queue_head_t *q, int state, long timeout)
{
unsigned long flags;
wait_queue_t wait;
init_waitqueue_entry(&wait, current);
__set_current_state(state);
==========>suppose that after task A set state=TASK_INTERRUPTIBLE
, it is preempted by task B.
spin_lock_irqsave(&q->lock, flags);
...............................................................
}
asmlinkage void __sched schedule(void)
{
.......................................................................................................
if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
if (unlikely(signal_pending_state(prev->state, prev)))
prev->state = TASK_RUNNING;
else
deactivate_task(rq, prev, 1);
=============>This will remove task A from rq, but there are no
wait queue referring to A, so we lose A.
switch_count = &prev->nvcsw;
}
..................................................................................................
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/