Re: [PATCH] x86: slightly shorten __ticket_spin_trylock() (v2)

From: Jan Beulich
Date: Thu Dec 03 2009 - 06:13:31 EST


>>> Ingo Molnar <mingo@xxxxxxx> 03.12.09 11:49 >>>
>Looks much cleaner - and should give us pretty much the same savings as
>the previous patch, right? (if not, do you have a size comparison?)

With upstream code there doesn't appear to be a difference in the
generated code. I noted, however, that with the spinlock contention
patch I have pending as a potential replacement for pv-ops spin locks
(which adds a conditional in the trylock functions) the compiler I use
no longer eliminates one of the two tests of the outcome of the
locking attempt.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/