Re: [PATCH 2.6.32 3/3] net: Make ks8851 snl work under BeagleZippy combo board

From: David Miller
Date: Thu Dec 03 2009 - 19:05:19 EST


From: "Ha, Tristram" <Tristram.Ha@xxxxxxxxxx>
Date: Thu, 3 Dec 2009 13:30:03 -0800

> From: Tristram Ha <Tristram.Ha@xxxxxxxxxx>
>
> The Micrel KSZ8851 SNL Ethernet chip is used in the OMAP Beagle Zippy combo board. Requesting interrupt using level triggering flag hangs the system because the interrupt handling routine is called continually. Using edge triggering avoids this problem. As a result, disabling interrupt may not be necessary.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@xxxxxxxxxx>

You say "may not be necessary", do you actually know for sure?

This seems questionable, if the interrupt disabling was there
for a reason what has changed to make it such that it is no
longer necessary?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/