Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack

From: David Howells
Date: Fri Dec 04 2009 - 04:43:03 EST


Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> > + flush_icache_range(mm->brk, brk);
> > return mm->brk = brk;
> > }
>
> probably want mm->brk + brk for the second argument

Ummm... Why? mm->brk and brk are both addresses - note the return statement
where brk just gets assigned to mm->brk.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/