Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack

From: Mike Frysinger
Date: Fri Dec 04 2009 - 05:21:43 EST


On Friday 04 December 2009 04:40:32 David Howells wrote:
> Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> > > + flush_icache_range(mm->brk, brk);
> > > return mm->brk = brk;
> > > }
> >
> > probably want mm->brk + brk for the second argument
>
> Ummm... Why? mm->brk and brk are both addresses - note the return
> statement where brk just gets assigned to mm->brk.

yeah, sorry. i was thinking sbrk where the argument is an increment, not a
new address.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.