Re: [PATCH 4/4]ARM: NUC900: enable uart support for nuc932

From: Wan ZongShun
Date: Fri Dec 04 2009 - 09:20:57 EST


2009/12/4 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>:
> On Wed, Dec 02, 2009 at 09:58:25PM +0800, Wan ZongShun wrote:
>> diff --git a/arch/arm/mach-w90x900/clock.h b/arch/arm/mach-w90x900/clock.h
>> index b9ea2e6..2a2a54a 100644
>> --- a/arch/arm/mach-w90x900/clock.h
>> +++ b/arch/arm/mach-w90x900/clock.h
>> @@ -14,8 +14,10 @@
>>
>> Â#ifndef CONFIG_CPU_NUC932
>> Â#define EXTCLK Â Â Â 15000000
>> +#define UARTCLK Â Â Â11313600
>> Â#else
>> Â#define EXTCLK Â Â Â 27000000
>> +#define UARTCLK Â Â Â57139200
>> Â#endif
>
> As far as I can see, these are the only thing which prevent a single
> kernel being built to cover both NUC900 and NUC932.
>
> Can we make their selection something which is done at runtime instead
> of compile time? ÂThis comments goes for patch 5837/1 in the patch
> system as well.
>
Do you mean that I should use following form instead?

"if (machine_is_nuc932evb())"
code....


--
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/