Re: [PATCH v2 1/2] acpi: support IBM SMBus CMI devices

From: Darrick J. Wong
Date: Fri Dec 04 2009 - 13:07:25 EST


On Fri, Dec 04, 2009 at 10:36:35AM -0700, Bjorn Helgaas wrote:
> On Friday 04 December 2009 10:06:21 am Darrick J. Wong wrote:
> > On Tue, Oct 27, 2009 at 06:36:19PM +0100, Jean Delvare wrote:
> > > On Tue, 27 Oct 2009 10:30:01 -0700, Darrick J. Wong wrote:
> > > > On Tue, Oct 27, 2009 at 06:03:32PM +0100, Jean Delvare wrote:
> > > >
> > > > > I'm only half please with this. You change the function named, but it
> > > > > doesn't follow the calling convention of acpi_dock_match(), which is a
> > > > > little confusing.
> > > > >
> > > > > Anyway, I will need an ack from the ACPI people before I can pick this
> > > > > patch. Or maybe they should even push it upstream themselves.
> >
> > Len/Bjorn: Any opinion on this ACPI quirk patch to make i2c-scmi work on IBM
> > systems? I think the i2c-scmi part is in Jean's tree, but I still need this
> > second patch to the ACPI code itself. Did you pick it up, or should I resend?
>
> I'm a little confused as to where we left things. Can you repost
> the current series in a new thread? It looks like there might be
> places that use "SMBUSIBM" when they should use ACPI_SMBUS_IBM_HID.

That was fixed in the patch that Jean picked up, which is why I especially need
the ACPI portion which actually #defines ACPI_SMBUS_IBM_HID. :) I will repost
both patches soon.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/