Re: [PATCH] security: do not check mmap_min_addr on nommu systems

From: John Johansen
Date: Fri Dec 04 2009 - 17:44:40 EST


David Howells wrote:
> Eric Paris <eparis@xxxxxxxxxx> wrote:
>
>> +/* sec_flags for security_file_mmap */
>> +/* Only check the address portion */
>> +#define SECURITY_MMAP_ADDR_ONLY 0x01
>> +/* Do not do the address checks */
>> +#define SECURITY_MMAP_NOT_ADDR 0x02
>
> I'm still not happy with the names assigned to these constants.
>
> Can we call them:
>
> #define SECURITY_MMAP_ADDR_CHECK_ONLY 0x01
> #define SECURITY_MMAP_SKIP_ADDR_CHECK 0x02
>
> and then discard the comments?
I do like these suggested names a little better. Either way I am happy
with the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/