Re: [RFC PATCH 12/15] ima-path-check rework

[Hugh Dickins]

On Fri, 4 Dec 2009, Eric Paris wrote:

I've not checked through this whole patch and your whole patchset,
but certainly when IMA came in, I felt (and said) that these calls
should be done at a lower level, so as not to affect each filesystem.
So I thoroughly approve of the direction of your patchset, even
though I cannot vouch for the details of it.  Thank you, Eric.

Hugh

> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -29,7 +29,6 @@
>  #include <linux/mm.h>
>  #include <linux/module.h>
>  #include <linux/swap.h>
> -#include <linux/ima.h>
>  
>  static struct vfsmount *shm_mnt;
>  
> @@ -2655,8 +2654,6 @@ struct file *shmem_file_setup(const char *name, loff_t size, unsigned long flags
>  	if (!file)
>  		goto put_dentry;
>  
> -	ima_counts_get(file);
> -
>  #ifndef CONFIG_MMU
>  	error = ramfs_nommu_expand_for_mapping(inode, size);
>  	if (error) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/