Re: debugging oops after disconnecting Nexio USB touchscreen

[Andreas Mohr]

Hi,

On Sat, Dec 05, 2009 at 12:16:13PM -0500, Alan Stern wrote:
> On Sat, 5 Dec 2009, Andreas Mohr wrote:
> 
> > Hi,
> > 
> > > Furthermore, the patch shows that the second-to-last argument to 
> > > usb_fill_bulk_urb() -- the completion function -- is NULL.  That is 
> > > strictly illegal and it should have caused an oops as soon as the URB 
> > > was used.
> > 
> > Then there's definitely a WARN_ON or so missing in
> > static inline void usb_fill_bulk_urb()
> 
> No there isn't.  That inline just fills in a bunch of fields.

After the fact I've been thinking that yes, such an inline helper
isn't really an appropriate location.

> > And highly likely more checks in those areas that are causing my (and
> > other people's) ftdi_sio tests and USB audio (MIPS mmap) to fail.
> > Followup soon.
> 
> Sometimes having too many checks is worse than having too few, 
> especially if the failure modes are relatively easy to handle.

True, many checks in all sorts of user places instead of the one core
place where it matters can clutter things. Especially since the WARN_ON
checks are unconditional, not a debug-only setting.

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/