Re: [GIT PULL] PM updates for 2.6.33

[Linus Torvalds]

On Sun, 6 Dec 2009, Arjan van de Ven wrote:
> 
> in suspend, there's a PCI device (:1b) that does take some time, which
> is the audio controller. The bulk of the time is in the serio driver
> though..

That serio thing is disgusting. We had serious problems with the serial 
driver timeouts for boot-time optimizations too, didn't we?

I assume that you don't even _use_ that serial port, do you? Or is it open 
for serial console logging or something? If it isn't even open, we 
shouldn't waste any time on the hardware.

Your graph seems to say that serio1 shutdown is roughly from 29.40 to 
29.85, ie almost half a second. That's just bogus. 

I don't see where it comes from, though. It looks like we have

 - pciserial_suspend_ports/serial_pnp_suspend ->
      serial8250_suspend_port ->
        uart_suspend_port ->
          (wait for tx_empty, but only for ASYNC_INITIALIZED, which 
	  shouldn't be true if it's closed, and should be limited to 30ms)
          uart_change_pm ->
            serial8250_pm

and none of them look like they should take anywhere close to half a 
second. So I'm obviously missing something, and your chart didn't include 
the sleep/wakeup pairs.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/