Re: [PATCH 28/31] Constify struct super_operations for 2.6.32 v1

From: Al Viro
Date: Mon Dec 07 2009 - 20:51:54 EST


On Tue, Dec 08, 2009 at 01:06:38AM +0100, Emese Revfy wrote:

> DEBUG_RODATA catches the unwanted write attempt at runtime whereas
> my patch will catch it at compile time. I think it's better to detect
> an error as early as possible.

Not when the price is readability. Moreover, you *still* are not
covering the real policy - these suckers should be statically allocated,
not just never modified.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/