Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoringdriver

[Pavel Machek]

> > > > That's certainly better. But... why not return signed value? Current
> > > > flowing from the battery is certainly very different from current
> > > > flowing into it...
> > > 
> > > You are totally right ;)
> > > 
> > > Just test it, when flowing from the battery, the value is negative, and
> > > when flowing into the battery, the value is positive, so, no abs()
> > > needed. thanks!
> > 
> > Make it return -value, then. I believe other code uses >0 values for
> > discharge.
> 
> Done, but any document/standard about it?

Not sure, feel free to patch the documentation, too :-).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/