Re: Async resume patch (was: Re: [GIT PULL] PM updates for 2.6.33)

[Alan Stern]

On Tue, 8 Dec 2009, Rafael J. Wysocki wrote:

> BTW, is there a good reason why completion_done() doesn't use spin_lock_irqsave
> and spin_unlock_irqrestore?  complete() and complete_all() use them, so why not
> here?

And likewise in try_wait_for_completion().  It looks like a bug.  Maybe 
these routines were not intended to be called with interrupts disabled, 
but that requirement doesn't seem to be documented.  And it isn't a 
natural requirement anyway.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/