Re: [PATCH] irq: handle irq0 special only on x86

From: AmÃrico Wang
Date: Wed Dec 09 2009 - 04:28:31 EST


2009/12/9 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>:
> I just noticed this when digging in the irq handling. ÂAt least for arm
> this doesn't make sense. ÂNot sure if x86 is the only arch this test
> is valid for, but probably it is.

No, it is not.

Try grep -Inr 'irq0' arch/*/kernel.


>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> ---
> Âkernel/irq/spurious.c | Â Â2 ++
> Â1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> index 22b0a6e..4996b66 100644
> --- a/kernel/irq/spurious.c
> +++ b/kernel/irq/spurious.c
> @@ -199,8 +199,10 @@ try_misrouted_irq(unsigned int irq, struct irq_desc *desc,
> Â Â Â Âif (irqfixup < 2)
> Â Â Â Â Â Â Â Âreturn 0;
>
> +#if defined(CONFIG_ARCH_X86)
> Â Â Â Âif (!irq)
> Â Â Â Â Â Â Â Âreturn 1;
> +#endif
>
> Â Â Â Â/*
> Â Â Â Â * Since we don't get the descriptor lock, "action" can
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/