Re: [GIT PULL] tracing/kprobes: Fix field creation's bad errorhandling

[Ingo Molnar]

* Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Frederic Weisbecker wrote:
> > Ingo,
> > 
> > Please pull the tracing/fixes branch that can be found at:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> > 	tracing/fixes
> > 
> > Thanks,
> > 	Frederic
> > ---
> > 
> > Frederic Weisbecker (1):
> >       tracing/kprobes: Fix field creation's bad error handling
> > 
> > 
> >  kernel/trace/trace_kprobe.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > ---
> > From 12e22dfaaee46f70762beb1982a7b86a68317b11 Mon Sep 17 00:00:00 2001
> > From: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Date: Tue, 8 Dec 2009 10:00:04 +0100
> > Subject: [PATCH] tracing/kprobes: Fix field creation's bad error handling
> > Cc: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Li Zefan <lizf@xxxxxxxxxxxxxx>
> > 
> > When we define the common event fields in kprobe, we invert the error
> > handling and return immediately in case of success. Then we omit
> > to define specific kprobes fields (ip and nargs), and specific
> > kretprobes fields (func, ret_ip, nargs). And we only define them
> > when we fail to create common fields.
> > 
> > The most visible consequence is that we can't create filter for
> > k(ret)probes specific fields.
> > 
> > This patch re-invert the success/error handling to fix it.
> > 
> > Reported-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> 
> Thanks for fix that.
> 
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> 
> 
> Ingo, I think this should go to tip:urgent.

Will apply, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/