Re: [PATCH] kmemcheck: make bitfield annotations truly no-ops whendisabled

From: Pekka Enberg
Date: Wed Dec 09 2009 - 08:31:44 EST


Andrew Morton kirjoitti:
On Sun, 6 Dec 2009 18:42:13 +0100
Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

It turns out that even zero-sized struct members (int foo[0];) will affect
the struct layout, causing us in particular to lose 4 bytes in struct sock.

This patch fixes the regression in CONFIG_KMEMCHECK=n case.

Which kernel version is the regression relative to?

AFAICT, it dates back to 2.6.31 when kmemcheck was introduced in mainline. Vegard?

Should we backport this into 2.6.32.x?

I guess so. Eric, how bad is the regression?

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/