Re: [PATCH] [19/31] mm: export stable page flags

[Matt Mackall]

On Wed, 2009-12-09 at 10:00 +0800, Wu Fengguang wrote:
> On Wed, Dec 09, 2009 at 06:27:31AM +0800, Matt Mackall wrote:
> > On Tue, 2009-12-08 at 22:16 +0100, Andi Kleen wrote:
> > > From: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> > > 
> > > Rename get_uflags() to stable_page_flags() and make it a global function
> > > for use in the hwpoison page flags filter, which need to compare user
> > > page flags with the value provided by user space.
> > > 
> > > Also move KPF_* to kernel-page-flags.h for use by user space tools.
> > > 
> > > CC: Matt Mackall <mpm@xxxxxxxxxxx>
> > > CC: Nick Piggin <npiggin@xxxxxxx>
> > > CC: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
> > > CC: Andi Kleen <andi@xxxxxxxxxxxxxx>
> > > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> > > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > 
> > Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>
> 
> Andi and Matt,
> 
> Sorry the stable_page_flags() will be undefined on
> !CONFIG_PROC_PAGE_MONITOR (it is almost always on,
> except for some embedded systems).
> 
> Currently the easy solution is to add a Kconfig dependency to
> CONFIG_PROC_PAGE_MONITOR.  When there comes more users (ie. some
> ftrace event), we can then always compile in stable_page_flags().

No objections.

Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/