Re: [PATCH] Coding style correction on some drivers that use Generic HDLC

From: Jiri Kosina
Date: Wed Dec 09 2009 - 18:27:06 EST


On Wed, 9 Dec 2009, Rudy Matela wrote:

> > It is ok until the driver is removed, if this "issue" is not fixed it
> > will trigger any check-coding-style and generate new patches. Since it
> > involves no code changes it is harmless.
> Sould I keep sending coding style corrections to the Linux Kernel?
> I'm trying to help, but if i'm just being annoying, please tell me and
> I can try to contribute in a better way. :-)

Coding style corrections (if they really improve readability of the code),
comment fixes (if they really make grepping for things better or make the
whole text more understandable) are welcome and I will happily merge them.

What I usually don't merge are purely whitespace "fixes", which don't
really fix anything in fact.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/