Re: [PATCH] sched: Memory leak in two error corner cases
From: Ingo Molnar
Date: Thu Dec 10 2009 - 03:02:53 EST
* Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> wrote:
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9841,8 +9841,10 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
>
> se = kzalloc_node(sizeof(struct sched_entity),
> GFP_KERNEL, cpu_to_node(i));
> - if (!se)
> + if (!se) {
> + kfree(cfs_rq);
> goto err;
> + }
would be nice to turn this into a regular pattern of:
if (!se)
goto err_kfree;
where err_kfree does the kfree.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/