Re: [RFC mm][PATCH 1/5] mm counter cleanup

From: Christoph Lameter
Date: Thu Dec 10 2009 - 12:32:18 EST


On Thu, 10 Dec 2009, KAMEZAWA Hiroyuki wrote:

> This patch modifies it to
> - Define them in mm.h as inline functions
> - Use array instead of macro's name creation. For making easier to add
> new coutners.

Reviewed-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>

> @@ -454,8 +456,8 @@ static struct mm_struct * mm_init(struct
> (current->mm->flags & MMF_INIT_MASK) : default_dump_filter;
> mm->core_state = NULL;
> mm->nr_ptes = 0;
> - set_mm_counter(mm, file_rss, 0);
> - set_mm_counter(mm, anon_rss, 0);
> + for (i = 0; i < NR_MM_COUNTERS; i++)
> + set_mm_counter(mm, i, 0);


memset? Or add a clear_mm_counter function? This also occurred earlier in
init_rss_vec().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/