Re: [PATCH -next] net: niu uses crc32, so select CRC32

From: Randy Dunlap
Date: Thu Dec 10 2009 - 17:00:53 EST


On Thu, 10 Dec 2009 13:51:38 -0800 (PST) David Miller wrote:

> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Date: Thu, 10 Dec 2009 09:31:03 -0800
>
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >
> > niu drivers uses crc32 functions, so it needs to select CRC32.
> >
> > niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Applied, thanks Randy.
>
> That dependency is quite indirect, it's due to ether_crc_*().
> I bet a quick grep for that will find several other drivers
> missing this Kconfig bit.

Yes, I've noticed that also...

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/