Re: [PATCH 4/5] alpha: Convert BUG() to use unreachable()

From: Matt Turner
Date: Thu Dec 10 2009 - 19:43:04 EST


On Thu, Dec 10, 2009 at 12:28 PM, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>
> CC: Richard Henderson <rth@xxxxxxxxxxx>
> CC: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
> CC: Matt Turner <mattst88@xxxxxxxxx>
> CC: linux-alpha@xxxxxxxxxxxxxxx
> ---
>  arch/alpha/include/asm/bug.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/alpha/include/asm/bug.h b/arch/alpha/include/asm/bug.h
> index 1720c8a..f091682 100644
> --- a/arch/alpha/include/asm/bug.h
> +++ b/arch/alpha/include/asm/bug.h
> @@ -13,7 +13,8 @@
>                "call_pal %0  # bugchk\n\t"                             \
>                ".long %1\n\t.8byte %2"                                 \
>                : : "i"(PAL_bugchk), "i"(__LINE__), "i"(__FILE__));     \
> -       for ( ; ; ); } while (0)
> +       unreachable();                                                  \
> +  } while (0)
>
>  #define HAVE_ARCH_BUG
>  #endif
> --
> 1.6.2.5

Thanks David. I've pushed this into my tree.

Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html