Re: Return value of print_graph_prologue

[Frederic Weisbecker]

On Fri, Dec 11, 2009 at 06:12:31PM +0800, Wenji Huang wrote:
> Hi,
>
> I got confused about the return value of print_graph_prologue. See:
>
> 805         /* Latency format */
> 806         if (trace_flags & TRACE_ITER_LATENCY_FMT) {
> 807                 ret = print_graph_lat_fmt(s, ent);
> 808                 if (ret == TRACE_TYPE_PARTIAL_LINE)
> 809                         return TRACE_TYPE_PARTIAL_LINE;
> 810         }
> 811
> 812         return 0;
> 813 }
>
> But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
> no difference between success and failure?
>
> Should it be TRACE_TYPE_HANDLED ?
>
> Regards,
> Wenji


Oh, good catch, I'm preparing a fix.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/