Re: [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier

[Felipe Balbi]

Hi,

On Fri, Dec 11, 2009 at 06:22:14PM +0100, ext sai pavan wrote:
> > @@ -628,7 +628,8 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
> >                else
> >                        twl4030_phy_resume(twl);
> >
> > -               twl4030charger_usb_en(status == USB_LINK_VBUS);
> > +               blocking_notifier_call_chain(&twl->otg.notifier, status,
> > +                               twl->otg.gadget);
> >        }
>
> You might not want to invoke blocking notifier chain(may sleep) from
> interrupt context. May be atomic notifier chain is appropriate here.

that's a threaded irq. Maybe we should patch all twl children to use 
request_threaded_irq() already. I'll test that tomorrow.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/