Re: [PATCH] Expose the irq_desc node in proc/irq

[Andrew Morton]

On Fri, 11 Dec 2009 10:25:32 -0600
Dimitri Sivanich <sivanich@xxxxxxx> wrote:

> Expose the irq_desc node as /proc/irq/*/node.
> 

:(

If the changelog provides no reason for the change, the recipient has
no reason to apply the patch.

>
> ...
> +	return single_open(file, irq_node_proc_show,  PDE(inode)->data);

I'd have expected checkpatch to complain about the double-space, but it
doesn't.

> ...
>  	/* create /proc/irq/<irq>/smp_affinity */
>  	proc_create_data("smp_affinity", 0600, desc->dir,
>  			 &irq_affinity_proc_fops, (void *)(long)irq);
> +
> +	proc_create_data("node", 0444, desc->dir,
> +			 &irq_node_proc_fops, (void *)(long)irq);
>  #endif
>  
>  	proc_create_data("spurious", 0444, desc->dir,

This should be documented in Documentation/filesystems/proc.txt,
alongside smp_affinity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/