Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string

[Frederic Weisbecker]

On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote:
> On Sun, 2009-12-13 at 07:37 +0000, tip-bot for Joe Perches wrote:
> > Commit-ID:  4819568f23a8bef0ca99b740ca60fe2450ab0aac
> > Gitweb:     http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac
> > Author:     Joe Perches <joe@xxxxxxxxxxx>
> > AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Sun, 13 Dec 2009 08:14:45 +0100
> > 
> > ftrace.h: Use common pr_info fmt string
> > 
> > Reduces fmt string space a bit.
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > LKML-Reference: <1260651974.2637.4.camel@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > ---
> >  include/trace/ftrace.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> > index d1b3de9..c4eca38 100644
> > --- a/include/trace/ftrace.h
> > +++ b/include/trace/ftrace.h
> > @@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\
> >  	ret = register_trace_##call(ftrace_raw_event_##call);		\
> >  	if (ret)							\
> >  		pr_info("event trace: Could not activate trace point "	\
> > -			"probe to " #call "\n");			\
> > +			"probe to %s\n", #call);			\
> 
> This reduces format string space a bit, but doesn't it just add another
> string to the string tables #func == "func" as well as add code to pass
> in another parameter?
> 
> -- Steve


Yeah, I don't understand the purpose of this patch either...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/