Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone

From: Andi Kleen
Date: Mon Dec 14 2009 - 11:19:56 EST


On Mon, Dec 14, 2009 at 09:23:19AM -0500, Larry Woodman wrote:
> On Mon, 2009-12-14 at 14:08 +0100, Andi Kleen wrote:
> > Rik van Riel <riel@xxxxxxxxxx> writes:
> >
> > > +max_zone_concurrent_reclaim:
> > > +
> > > +The number of processes that are allowed to simultaneously reclaim
> > > +memory from a particular memory zone.
> > > +
> > > +With certain workloads, hundreds of processes end up in the page
> > > +reclaim code simultaneously. This can cause large slowdowns due
> > > +to lock contention, freeing of way too much memory and occasionally
> > > +false OOM kills.
> > > +
> > > +To avoid these problems, only allow a smaller number of processes
> > > +to reclaim pages from each memory zone simultaneously.
> > > +
> > > +The default value is 8.
> >
> > I don't like the hardcoded number. Is the same number good for a 128MB
> > embedded system as for as 1TB server? Seems doubtful.
> >
> > This should be perhaps scaled with memory size and number of CPUs?
>
> Remember this a per-zone number.

A zone could be 64MB or 32GB. And the system could have 1 or 1024 CPUs.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/