Re: [PATCH] laptop-mode: Make flushes per-device

[Matthew Garrett]

On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote:

> That's because it is messy, why are you passing the request in? It
> would be a lot more sane to pass in the queue, better still the backing
> device.

It seemed conceptually cleaner for the completion to refer to the 
request rather than anything else, but that's easily fixed.

> What guarentees that the timer isn't running when the bdi goes away?

Good point. I'll fix these and resend.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/