Re: [RFC, PATCH 2/4] elf_core_dump(): Remove DUMP_WRITE macro

[Daisuke HATAYAMA]

> On Tue, Dec 15, 2009 at 10:41 AM, Daisuke HATAYAMA
> <d.hatayama@xxxxxxxxxxxxxx> wrote:
> > In DUMP_WRITE macro, some local variables and goto statement are used
> > implicitly, which makes it confusing to understand how the dumping
> > process behaves. So, clean up it by unfolding the macro body directly
> > to the point where the original macro is used plus a bit of style
> > change.
> >
> > Now that the previous patch replaced ELF_CORE_EXTRA_* macros in
> > fs/binfmt_elf.c, there is no users for DUMP_WRITE macro in
> > fs/binfmt_elf.c. Thus remove the definition of DUMP_WRITE macro.
> >
> > Signed-off-by: Daisuke HATAYAMA <d.hatayama@xxxxxxxxxxxxxx>
> 
> 
> I assume you at least did a build test?

Oh..sorry. I have forgotten writting about test.

For IA64, i386 and UML-i386, I tested on the real machine.
For s390, arm and xtensa, I only did a build test.

> I like this patch:

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/