Re: [mm][RFC][PATCH 0/11] mm accessor updates.

From: Andi Kleen
Date: Wed Dec 16 2009 - 05:11:27 EST


On Wed, Dec 16, 2009 at 12:00:11PM +0900, KAMEZAWA Hiroyuki wrote:
> This is from Christoph Lameter's mm_accessor patch posted 5/Nov.
>
> Replacing all access to mm->mmap_sem with mm-accessor functions as
> mm_read_lock,
> mm_write_lock,
> etc...
>
> This kind of function allows us to improve page fault performance etc..
> For example, skil down_read(mmap_sem) in some situation.
> (as: http://marc.info/?l=linux-mm&m=125809791306459&w=2)

The problem is that it also slows down the writers, and we have
some workloads where writing is the bottleneck.

I don't think this is the right trade off at this time.

Also the patches didn't fare too well in testing unfortunately.

I suspect we'll rather need multiple locks split per address
space range.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/