Re: [uClinux-dev] Re: [PATCH] NOMMU: add [stack] label to per-process maps output

From: Mike Frysinger
Date: Wed Dec 16 2009 - 14:36:58 EST


On Wed, Dec 16, 2009 at 11:59, David Howells wrote:
> Mike Frysinger wrote:
>
>> + Â Â Â Â Â Â if (vma->vm_start <= mm->start_brk &&
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â vma->vm_end >= mm->brk) {
>
> Hmmm... ÂThat ought to involve mm->start_stack somewhere... Â(Or, more
> probably, task->stack_start:-/)

in practice, it's probably always the same result, but you're right of
course. when i looked through the elf_fdpic code, i looked at the
start_brk mmap() and missed the later start_stack assignment later on.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/