Re: [patch 1/1] devtmpfs: Convert dirlock to a mutex

From: Greg KH
Date: Wed Dec 16 2009 - 17:20:34 EST


On Wed, Dec 16, 2009 at 09:31:33PM -0000, Thomas Gleixner wrote:
> devtmpfs has a rw_lock dirlock which serializes delete_path and
> create_path.
>
> This code was obviously never tested with the usual set of debugging
> facilities enabled. In the dirlock held sections the code calls:
>
> - vfs functions which take mutexes
> - kmalloc(, GFP_KERNEL)
>
> In both code pathes the might sleep warning triggers and spams dmesg.
>
> Convert the rw_lock to a mutex. There is no reason why this needs to
> be a rwlock.

Many thanks, this is correct. I'll go queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/