Re: -tip: origin tree boot crash

From: Christoph Hellwig
Date: Thu Dec 17 2009 - 04:36:23 EST


On Thu, Dec 17, 2009 at 09:32:16AM +0000, Al Viro wrote:
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 4012885..e82adc2 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -1206,7 +1206,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode,
> * NOTE: filesystems with their own locking have to handle this
> * on their own.
> */
> - if (dio->flags & DIO_LOCKING) {
> + if (flags & DIO_LOCKING) {
> if (unlikely((rw & WRITE) && retval < 0)) {
> loff_t isize = i_size_read(inode);
> if (end > isize)

Hmm, yes that should fix it. Dio is freed at that point.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/