Re: [Patch] thinkpad_acpi: fix a build error

[Helight.Xu]

Takashi Iwai wrote:
> At Fri, 18 Dec 2009 17:42:34 +0800,
> Xiaotian Feng wrote:
>   
> > Ingo already sent this patch yesterday.
> > http://lkml.org/lkml/2009/12/17/25
> >
> >
> > On Fri, Dec 18, 2009 at 5:28 PM, Amerigo Wang <amwang@xxxxxxxxxx> wrote:
> >     
> > > This patch fixes the following build error:
> > >
> > >  Building modules, stage 2.
> > >  MODPOST 1834 modules
> > > ERROR: "snd_card_create" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_ctl_notify" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_ctl_boolean_mono_info" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_ctl_new1" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_card_free" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_card_register" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > > ERROR: "snd_ctl_add" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> > >
> > > Cc: Len Brown <len.brown@xxxxxxxxx>
> > > Cc: Corentin Chary <corentincj@xxxxxxxxxx>
> > > Cc: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> > > Cc: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
> > > Reported-by: Helight.Xu <helight.xu@xxxxxxxxx>
> > > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> > > Tested-by: Helight.Xu <helight.xu@xxxxxxxxx>
> > >
> > > ---
> > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > > index fc5bf9d..596966c 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -215,6 +215,7 @@ config THINKPAD_ACPI
> > >        depends on ACPI
> > >        depends on INPUT
> > >        depends on RFKILL || RFKILL = n
> > > +       depends on SOUND
> > >       
>
> The patch isn't correct (I guess the upstream fix is same?).
>
> CONFIG_SOUND is a global config for sound subsystem.  The relevant
> functions are ALSA core part, which is CONFIG_SND.
> So, the fix should be:
>
> 	depends on SND
>   
yes, I think so ! It should be "depends on SND", and I am testing now!
> instead.
>
>
> Takashi
>
>   


--
Zhenwen Xu - Seven Helight
Home Page: http://zhwen.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/