Re: [Patch] thinkpad_acpi: fix a build error

[Henrique de Moraes Holschuh]

On Fri, 18 Dec 2009, Takashi Iwai wrote:
> At Fri, 18 Dec 2009 12:28:15 -0200,
> Henrique de Moraes Holschuh wrote:
> > On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > > The patch isn't correct (I guess the upstream fix is same?).
> > > 
> > > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > > functions are ALSA core part, which is CONFIG_SND.
> > > So, the fix should be:
> > > 
> > > 	depends on SND
> > > 
> > > instead.
> > 
> > Indeed.  Ingo already fixed that too.
> > 
> > Although I personally would prefer:
> > select SOUND
> > select SND
> 
> SND already depends on SOUND, so it's just superfluous.

No, it is not (test it).  Which is the main reason why select can be a pain.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/