Re: [PATCH x86/urgent] x86: Fix objdump version check in chkobjdump.awkfor different formats.

[Masami Hiramatsu]

Masami Hiramatsu wrote:
> Different version of objdump says its version in different way;
> 
> GNU objdump 2.16.1
> 
> or
> 
> GNU objdump version 2.19.51.0.14-1.fc11 20090722
> 
> This patch uses the first argument which starts with a number
> as version string.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Suggested-by: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  arch/x86/tools/chkobjdump.awk |   16 +++++++++++++---
>  1 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk
> index 5bbb5a3..250dc79 100644
> --- a/arch/x86/tools/chkobjdump.awk
> +++ b/arch/x86/tools/chkobjdump.awk
> @@ -8,14 +8,24 @@ BEGIN {
>  	od_sver = 19;
>  }
>  
> -/^GNU/ {
> -	split($3, ver, ".");
> +/^GNU objdump/ {
> +	verstr = ""
> +	for (i = 3; i <= NF; i++)
> +		if (match($(i), "^[0-9]")) {
> +			verstr = $(i++);
                                   ^^^^oops, it's not needed!

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/