Re: [git patches] libata updates

From: Jeff Garzik
Date: Sat Dec 19 2009 - 15:11:24 EST


On 12/19/2009 02:05 PM, Linus Torvalds wrote:
On Sat, 19 Dec 2009, Jeff Garzik wrote:

to receive the following updates:

drivers/ata/libata-scsi.c | 2 +-
drivers/ata/libata-sff.c | 2 +-
drivers/ata/pata_hpt3x2n.c | 64 ++++++++++---------
drivers/ata/pata_octeon_cf.c | 2 +-
drivers/ata/sata_mv.c | 144 ++++++++++++++++++++++++++++++++++++------
5 files changed, 163 insertions(+), 51 deletions(-)
mode change 100644 => 100755 drivers/ata/sata_mv.c

WTF is that mode change?

It's introduced by commit 6481f2b52cd5411ea6342b749daf0e4f3b390d7b:
"sata_mv: add power management support for the platform driver", and it's
totally nonsensical.

I fixed that crazy stuff when merging, but you should look at your own
summaries a bit, and should have noticed that it was crazy. That file
isn't an executable.

Whoops, you're absolutely right. That's broken.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/