Re: [PATCH] scripts/checkpatch.pl: Add WARN on printk format spliton multiple lines

[Ingo Molnar]

* Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Sun, 2009-12-20 at 20:15 +0100, Ingo Molnar wrote:
> > Checkpatch should warn about printk 
> > lines that end with a '"', those are almost always a sign of some ill-advised 
> > break-the-string artifact.
> 
> Perhaps something like this:
> 
> diff from Andy Whitcroft's testing script,
> where logFunctions is defined.
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
> 
> --- a/scripts/checkpatch.pl-testing	2009-12-20 11:35:28.000000000 -0800
> +++ b/scripts/checkpatch.pl-testing	2009-12-20 11:35:46.000000000 -0800
> @@ -1398,6 +1398,11 @@
>  			WARN("line over 80 characters\n" . $herecurr);
>  		}
>  
> +#Logging function format split over multiple lines
> +		if ($line =~ /^\+\s*$logFunctions.*"\s*$/) {
> +			WARN("Don't split logging function format\n" . $herecurr);
> +		}
> +

Havent tested it but this check would be lovely to have.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/