Re: [PATCH] kbuild: correct size calculation of bzImgae / fix x86boot

From: H. Peter Anvin
Date: Mon Dec 21 2009 - 14:09:45 EST


On 12/21/2009 10:28 AM, H. Peter Anvin wrote:
> On 12/20/2009 06:11 AM, Sam Ravnborg wrote:
>>
>> The whole business using shell scripts to append the size seems broken.
>> How about moving this functionality to mkpiggy where we are
>> less shell script dependent.
>>
>
> Seems a helluva lot saner to me...
>
>> It includes the length also in the gzip case - I dunno if that matters.
>> Also I dunno if ".long" is the same on 32 and 64 bit.
>
> Well, gzip already has a length at the end... shouldn't really hurt
> anything, I suppose. ".long" is 32 bits on both 32 and 64 bits.
>

Note, though: mkpiggy is x86, but this also affects other
architectures... so probably additional changes are needed.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/