RE: [PATCH] prctl: return timerslack through pointer

[Smith, GeoffX]

Oops, my oversight.  In re: any patch I submitted 12/17/2009:

Signed-off-by: Geoff Smith <geoffx.smith@xxxxxxxxx>

-----Original Message-----
From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] 
Sent: Tuesday, December 22, 2009 1:51 PM
To: Smith, GeoffX
Cc: linux-kernel@xxxxxxxxxxxxxxx; Arjan van de Ven; stable@xxxxxxxxxx
Subject: Re: [PATCH] prctl: return timerslack through pointer

On Thu, 17 Dec 2009 16:17:15 -0800
"Smith, GeoffX" <geoffx.smith@xxxxxxxxx> wrote:

> This patch fixes the semantics of prctl() option PR_GET_TIMERSLACK
> to pass the return value through *arg2.
> 
> With this change, the option now follows the same conventions as the
> other "get" options added since 2.6.0, and also brings it into
> conformance with the advice in chapter 16 of Documentation/CodingStyle.
> 
> In addition, it effectively doubles the range of time slack to 4.29
> seconds (on a 32-bit architecture).
> 
> The timer slack feature was only added in Sep 2009 (new in 2.6.32.1), 
> so there are not any production applications to break.  I have also 
> repaired some unmatched signed/unsigned mismatches in timer slack
> calculations.
> 

If we're going to do this then we should backport the patch into
2.6.32.x as well.  And I agree that there is time to make this change.

> diff --git a/kernel/sys.c b/kernel/sys.c
> index 20ccfb5..e01da12 100644

You omitted the Signed-off-by: line (described in
Documentation/SubmittingPatches).  Please send one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/