Re: [this_cpu_xx V8 07/16] Module handling: Use this_cpu_xx to dynamicallyallocate counters

From: Tejun Heo
Date: Tue Dec 22 2009 - 21:05:27 EST


On 12/23/2009 12:57 AM, Christoph Lameter wrote:
> On Mon, 21 Dec 2009, Tejun Heo wrote:
>
>>
>>> Index: linux-2.6/kernel/trace/ring_buffer.c
>>> ===================================================================
>>> --- linux-2.6.orig/kernel/trace/ring_buffer.c 2009-12-18 13:13:24.000000000 -0600
>>> +++ linux-2.6/kernel/trace/ring_buffer.c 2009-12-18 14:15:57.000000000 -0600
>>> @@ -12,6 +12,7 @@
>>> #include <linux/hardirq.h>
>>> #include <linux/kmemcheck.h>
>>> #include <linux/module.h>
>>> +#include <asm/local.h>
>>
>> This doesn't belong to this patch, right? I stripped this part out,
>> added Cc: to Rusty and applied 1, 2, 7 and 8 to percpu branch. I'll
>> post the updated patch here. Thanks.
>
> If you strip this part out then ringbuffer.c will no longer compile
> since it relies on the "#include <local.h>" that is removed by this patch
> from the module.h file.

Oh... alright. I'll add that comment and drop the offending chunk and
recommit.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/