Re: [PATCH 9/15] arch/m68k: Use DIV_ROUND_CLOSEST

[Geert Uytterhoeven]

On Sun, Aug 2, 2009 at 09:47, Julia Lawall <julia@xxxxxxx> wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.

Thanks, applied.

> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression x,__divisor;
> @@
>
> - (((x) + ((__divisor) / 2)) / (__divisor))
> + DIV_ROUND_CLOSEST(x,__divisor)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
>
> ---
> Âarch/m68k/amiga/config.c      Â|  Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
> index 6e56275..002b9b0 100644
> --- a/arch/m68k/amiga/config.c
> +++ b/arch/m68k/amiga/config.c
> @@ -480,7 +480,7 @@ static void __init amiga_sched_init(irq_handler_t timer_routine)
> Â Â Â Âstatic struct resource sched_res = {
> Â Â Â Â Â Â Â Â.name = "timer", .start = 0x00bfd400, .end = 0x00bfd5ff,
> Â Â Â Â};
> - Â Â Â jiffy_ticks = (amiga_eclock+HZ/2)/HZ;
> + Â Â Â jiffy_ticks = DIV_ROUND_CLOSEST(amiga_eclock, HZ);
>
> Â Â Â Âif (request_resource(&mb_resources._ciab, &sched_res))
> Â Â Â Â Â Â Â Âprintk("Cannot allocate ciab.ta{lo,hi}\n");
>



-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/