Re: [BISECTED] drm: random hang since 620f378 "drm: prune modeswhen ..."

[Jesse Barnes]

On Mon, 21 Dec 2009 17:57:08 +0000
Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Monday 21 December 2009 16:06:43 Arnd Bergmann wrote:
> > 
> > -       if (IS_G4X(dev)) {
> > -               u16 gcfgc;
> > -
> > -               /* Adjust render clock... */
> > -               pci_read_config_word(dev->pdev, GCFGC, &gcfgc);
> > -
> > -               /* Down to minimum... */
> > -               gcfgc &= ~GM45_GC_RENDER_CLOCK_MASK;
> > -               gcfgc |= GM45_GC_RENDER_CLOCK_266_MHZ;
> > -
> > -               pci_write_config_word(dev->pdev, GCFGC, gcfgc);
> > -       } else if (IS_I965G(dev)) {
> > +       if (IS_I965G(dev)) {
> >                 u16 gcfgc;
> 
> This crashed again immediately, apparently because IS_I965G is a
> superset of IS_G4X (that seems counterintuitive), but not it seems to
> run using this modified version of the patch (half an hour so far).
> 

This code should be completely gone in Eric's drm-intel-next branch
(from
git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel.git), so
hopefully when that lands upstream (if it hasn't already) things will
be solid for you.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/