Re: tty: &&/|| confusion in mxser_get_ISA_conf()?

[Jiri Slaby]

On 12/31/2009 01:03 PM, Roel Kluin wrote:
> vi drivers/char/mxser.c +2460 and note:
> 
> if ((irq != regs[9]) || (irq != regs[10]))
> 
> Should this be an && ?

I would say not. It's a check whether irq is the same for all chips. It
jumps to a true branch iff at least one irq of the 8 is different (there
are 4 in each register). Does it make sense?

-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/