Re: [RFC][PATCH v3] readahead: introduce O_RANDOM forPOSIX_FADV_RANDOM

From: Christoph Hellwig
Date: Mon Jan 04 2010 - 02:33:46 EST


On Mon, Jan 04, 2010 at 04:17:19PM +1100, Stephen Rothwell wrote:
> > @@ -80,6 +80,10 @@
> > #define O_NDELAY O_NONBLOCK
> > #endif
> >
> > +#ifndef O_RANDOM
> > +#define O_RANDOM 010000000 /* random access pattern hint */
> > +#endif
>
> This value conflicts with O_CLOEXEC on alpha and parisc and O_NOATIME on
> sparc.

Also when I tried to use this value for O_RSYNC and tested it I could
not actually see it getting propagated by the open code.

Eitherway I don't think an O_ value is a good idea for a simple access
pattern hint.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/