Re: [PATCH] mm: move sys_mmap_pgoff from util.c

[Eric B Munson]

On Wed, 30 Dec 2009, Hugh Dickins wrote:

> Move sys_mmap_pgoff() from mm/util.c to mm/mmap.c and mm/nommu.c,
> where we'd expect to find such code: especially now that it contains
> the MAP_HUGETLB handling.  Revert mm/util.c to how it was in 2.6.32.
> 
> This patch just ignores MAP_HUGETLB in the nommu case, as in 2.6.32,
> whereas 2.6.33-rc2 reported -ENOSYS.  Perhaps validate_mmap_request()
> should reject it with -EINVAL?  Add that later if necessary.
> 
> Signed-off-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>

I think that -ENOSYS is the correcet response in the nommu case, but
I that can be added in a later patch.

Acked-by: Eric B Munson <ebmunson@xxxxxxxxxx>

Attachment: signature.asc
Description: Digital signature