Re: [PATCH] drivers/net/defxx.c: use %pM to show MAC address

[Maciej W. Rozycki]

On Wed, 30 Dec 2009, H Hartley Sweeten wrote:

> Use the %pM kernel extension to display the MAC address.
> 
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>

 Nack.  While I appreciate your effort, the FDDI standard defines opposite 
bit-ordering for MAC addresses written in the dash-separated and the 
colon-separated hexadecimal notation, which makes your change invalid, 
sorry (you'd have to bit-swap them too and that would make addresses 
counter-intuitive).  Please note that `ifconfig' consistently uses the 
dash-separated notation for FDDI interfaces too (I haven't checked other 
tools like those in the "iproute" package; they may be buggy).

 [I'd appreciate to be CCed on patch submissions to code I claim 
maintenance of too.]

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/