Re: [RFC][PATCH v4] readahead: introduce O_RANDOM forPOSIX_FADV_RANDOM

[Eric Paris]

On Tue, 2010-01-05 at 10:45 +0800, Wu Fengguang wrote:
> On Tue, Jan 05, 2010 at 10:28:24AM +0800, Stephen Rothwell wrote:
> > Hi Fengguang,
> > 
> > On Tue, 5 Jan 2010 10:26:50 +0800 Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:
> > >
> > > Where is it? I cannot grep find one in arch/.
> > > There is one defined in include/asm-generic/fcntl.h:
> > > 
> > > #ifndef O_SYNC
> > > #define __O_SYNC        04000000
> > > #define O_SYNC          (__O_SYNC|O_DSYNC)
> > > #endif
> > > 
> > > However it has one less '0' :)
> > 
> > Search for 0x800000 ...
> 
> Thanks, I got it..
> 
> Does that mean __O_SYNC would be _accidentally_ masked out in
> __dentry_open() by the newly introduced fanotify bit?
> 
>         f->f_flags = (flags & ~(FMODE_EXEC | FMODE_NONOTIFY));
> 
> The above line is added in commit f67cee7b50b004357be383,
> and can be fixed by the below patch.
> 
> Eric, what do you think?

I'll try to get that patch added tonight/tomorrow (although I'm
basically without internet until the 7th).

Al mentioned to me (for a completely unrelated reason) he'd rather see
internal and external open flags split, so we don't have that stupidity
of masking off FMODE_EXEC and FMODE_NONOTIFY.  I'll probably try to work
on something like that, after I'm back working.  Maybe Al or Christoph
would like to actually review this work and tell me everything else they
don't like?

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/