Re: [patch 5/6] sparc: cpumask_of_node() should handle -1 as a node

From: David Miller
Date: Wed Jan 06 2010 - 23:22:29 EST


From: Anton Blanchard <anton@xxxxxxxxx>
Date: Wed, 06 Jan 2010 15:55:14 +1100

> pcibus_to_node can return -1 if we cannot determine which node a pci bus
> is on. If passed -1, cpumask_of_node will negatively index the lookup array
> and pull in random data:
>
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
> 00000000,00000003,00000000,00000000
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
> 64-65
>
> Change cpumask_of_node to check for -1 and return cpu_all_mask in this
> case:
>
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
> ffffffff,ffffffff,ffffffff,ffffffff
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
> 0-127
>
> Signed-off-by: Anton Blanchard <anton@xxxxxxxxx>

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/